improved typing

.idea/dictionaries/haroldmartin.xml

@@ -12,7 +12,9 @@
       <w>descrambling</w>
       <w>eurl</w>
       <w>ficano</w>
+      <w>filenames</w>
       <w>filesize</w>
+      <w>gangnam</w>
       <w>itag</w>
       <w>itags</w>
       <w>lsig</w>
@@ -23,11 +25,13 @@
       <w>nficano</w>
       <w>noqa</w>
       <w>noreorder</w>
+      <w>nosec</w>
       <w>ntfs</w>
       <w>prog</w>
       <w>pytube</w>
       <w>recompiles</w>
       <w>samp</w>
+      <w>scodecs</w>
       <w>streamability</w>
       <w>stty</w>
       <w>tracklist</w>

pytube/__main__.py

@@ -69,6 +69,7 @@ class YouTube:
         self.player_config_args: Dict = {}  # inline js in the html containing
         # streams
         self.age_restricted: Optional[bool] = None
+        self.vid_descr: Optional[str] = None
 
         self.fmt_streams: List[Stream] = []
         self.caption_tracks: List[Caption] = []

pytube/cli.py

@@ -235,7 +235,6 @@ def download_by_resolution(
     :param str target:
         Target directory for download
     """
-    # TODO(nficano): allow dash itags to be selected
     stream = youtube.streams.get_by_resolution(resolution)
     if stream is None:
         print(f"Could not find a stream with resolution: {resolution}")

pytube/contrib/playlist.py

@@ -38,7 +38,7 @@ class Playlist:
         # Needs testing with non-English
         self.last_update: Optional[date] = None
         results = re.search(
-            r"<li>Last updated on (\w{3}) (\d{1,2}), (\d{4})<\/li>", self.html
+            r"<li>Last updated on (\w{3}) (\d{1,2}), (\d{4})</li>", self.html
         )
         if results:
             month, day, year = results.groups()

pytube/monostate.py

@@ -8,7 +8,7 @@ from typing_extensions import Protocol
 class OnProgress(Protocol):
     def __call__(
         self,
-        stream: Any,
+        stream: bytes,
         chunk: Any,
         file_handler: io.BufferedWriter,
         bytes_remaining: int,

pytube/query.py

@@ -287,8 +287,8 @@ class StreamQuery:
     def get_audio_only(self, subtype: str = "mp4") -> Optional[Stream]:
         """Get highest bitrate audio stream for given codec (defaults to mp4)
 
-        :param str codec:
-            Audio codec, defaults to mp4
+        :param str subtype:
+            Audio subtype, defaults to mp4
         :rtype: :class:`Stream <Stream>` or None
         :returns:
             The :class:`Stream <Stream>` matching the given itag or None if

pytube/streams.py

@@ -264,7 +264,7 @@ class Stream:
         additional callback is defined in the monostate. This is exposed to
         allow things like displaying a progress bar.
 
-        :param str chunk:
+        :param bytes chunk:
             Segment of media file binary data, not yet written to disk.
         :param file_handler:
             The file handle where the media is being written to.

tests/test_cli.py

@@ -86,7 +86,7 @@ def test_download_caption_with_language_not_found(youtube):
 
 def test_display_progress_bar(capsys):
     cli.display_progress_bar(bytes_received=25, filesize=100, scale=0.55)
-    out, err = capsys.readouterr()
+    out, _ = capsys.readouterr()
     assert "25.0%" in out