handle missing bitrate

pytube/__main__.py

@@ -276,7 +276,7 @@ class YouTube:
         """
         return self.player_response.get("videoDetails", {}).get(
             "shortDescription"
-        ) or extract.get_vid_descr(self.watch_html)
+        ) or extract._get_vid_descr(self.watch_html)
 
     @property
     def rating(self) -> float:

pytube/extract.py

@@ -182,7 +182,7 @@ def get_ytplayer_config(html: str, age_restricted: bool = False) -> Any:
     return json.loads(yt_player_config)
 
 
-def get_vid_descr(html: Optional[str]) -> str:
+def _get_vid_descr(html: Optional[str]) -> str:
     html_parser = PytubeHTMLParser()
     if html:
         html_parser.feed(html)

pytube/query.py

@@ -172,8 +172,8 @@ class StreamQuery:
 
     def _filter(self, filters: List[Callable]) -> "StreamQuery":
         fmt_streams = self.fmt_streams
-        for fn in filters:
-            fmt_streams = filter(fn, fmt_streams)
+        for filter_lambda in filters:
+            fmt_streams = filter(filter_lambda, fmt_streams)
         print(fmt_streams)
         return StreamQuery(list(fmt_streams))
 

pytube/streams.py

@@ -59,7 +59,7 @@ class Stream:
         self.video_codec, self.audio_codec = self.parse_codecs()
 
         self.is_otf: bool = stream["is_otf"]
-        self.bitrate: int = stream["bitrate"]
+        self.bitrate: Optional[int] = stream["bitrate"]
 
         self._filesize: Optional[int] = None  # filesize in bytes
 
@@ -159,16 +159,18 @@ class Stream:
 
     @property
     def filesize_approx(self) -> int:
-        """Get approximate filesize of the video, avoiding HTTP call
+        """Get approximate filesize of the video
+
+        Falls back to HTTP call if there is not sufficient information to approximate
 
         :rtype: int
         :returns: size of video in bytes
         """
-        if self._monostate.duration:
+        if self._monostate.duration and self.bitrate:
             bits_in_byte = 8
             return int((self._monostate.duration * self.bitrate) / bits_in_byte)
-        else:
-            return self.filesize
+
+        return self.filesize
 
     @property
     def default_filename(self) -> str:

tests/test_extract.py

@@ -57,7 +57,7 @@ def test_get_vid_desc(cipher_signature):
         "http://sptfy.com/PSY\n"
         "http://weibo.com/psyoppa"
     )
-    assert extract.get_vid_descr(cipher_signature.watch_html) == expected
+    assert extract._get_vid_descr(cipher_signature.watch_html) == expected
 
 
 def test_mime_type_codec():