added test_download_with_playlist_video_error

pytube/cli.py

@@ -426,11 +426,11 @@ def download_caption(
         _print_available_captions(youtube.captions)
         return
 
-    caption = youtube.captions.get_by_language_code(lang_code=lang_code)
-    if caption:
+    try:
+        caption = youtube.captions[lang_code]
         downloaded_path = caption.download(title=youtube.title, output_path=target)
         print(f"Saved caption file to: {downloaded_path}")
-    else:
+    except KeyError:
         print(f"Unable to find caption with code: {lang_code}")
         _print_available_captions(youtube.captions)
 

pytube/query.py

@@ -369,7 +369,9 @@ class CaptionQuery(Mapping):
         self.lang_code_index = {c.code: c for c in captions}
 
     @deprecated("This object can be treated as a dictionary, i.e. captions['en']")
-    def get_by_language_code(self, lang_code: str) -> Optional[Caption]:
+    def get_by_language_code(
+        self, lang_code: str
+    ) -> Optional[Caption]:  # pragma: no cover
         """Get the :class:`Caption <Caption>` for a given ``lang_code``.
 
         :param str lang_code:

tests/test_captions.py

@@ -38,7 +38,7 @@ def test_caption_query_get_by_language_code_when_exists():
         {"url": "url2", "name": {"simpleText": "name2"}, "languageCode": "fr"}
     )
     caption_query = CaptionQuery(captions=[caption1, caption2])
-    assert caption_query.get_by_language_code("en") == caption1
+    assert caption_query["en"] == caption1
 
 
 def test_caption_query_get_by_language_code_when_not_exists():
@@ -49,7 +49,9 @@ def test_caption_query_get_by_language_code_when_not_exists():
         {"url": "url2", "name": {"simpleText": "name2"}, "languageCode": "fr"}
     )
     caption_query = CaptionQuery(captions=[caption1, caption2])
-    assert caption_query.get_by_language_code("hello") is None
+    with pytest.raises(KeyError):
+        not_found = caption_query["hello"]
+        assert not_found is not None  # should never reach here
 
 
 @mock.patch("pytube.captions.Caption.generate_srt_captions")

tests/test_cli.py

@@ -6,6 +6,7 @@ from unittest.mock import MagicMock, patch
 import pytest
 
 from pytube import cli, StreamQuery, Caption, CaptionQuery
+from pytube.exceptions import PytubeError
 
 parse_args = cli._parse_args
 
@@ -236,6 +237,29 @@ def test_download_with_playlist(perform_args_on_youtube, playlist, youtube):
     perform_args_on_youtube.assert_called_with(youtube, args)
 
 
+@mock.patch("pytube.cli.YouTube")
+@mock.patch("pytube.cli.Playlist")
+@mock.patch("pytube.cli._perform_args_on_youtube")
+def test_download_with_playlist_video_error(
+    perform_args_on_youtube, playlist, youtube, capsys
+):
+    # Given
+    cli.safe_filename = MagicMock(return_value="safe_title")
+    parser = argparse.ArgumentParser()
+    args = parse_args(parser, ["https://www.youtube.com/playlist?list=PLyn"])
+    cli._parse_args = MagicMock(return_value=args)
+    videos = [youtube]
+    playlist_instance = playlist.return_value
+    playlist_instance.videos = videos
+    perform_args_on_youtube.side_effect = PytubeError()
+    # When
+    cli.main()
+    # Then
+    playlist.assert_called()
+    captured = capsys.readouterr()
+    assert "There was an error with video" in captured.out
+
+
 @mock.patch("pytube.cli.YouTube")
 @mock.patch("pytube.StreamQuery")
 @mock.patch("pytube.Stream")