Datasets:

Partha117

/

apache_bug_reports

like 1

Bug 47583 Fix occasional test failure in TestConcurrency

2009-07-26 06:43:28

resolved fixed

278dedc

modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java

Tomcat

Bug 47576 Javadoc errors - Exception name misspelt

The files FairBlockingQueue.java MultiLockFairBlockingQueue.java use * @throws UnsupportedOperation This should be * @throws UnsupportedOperationException

2009-07-24 17:27:54

resolved fixed

abbb922

modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/MultiLockFairBlockingQueue.java

Tomcat

Bug 47569 Test cases do not clear up afterwards

Some of the test cases (e.g. TestTomcat) start a Tomcat server, This creates the directory tree tomcat.8080/work... which is not deleted when the test finishes.

2009-07-23 13:08:38

resolved fixed

a9e00d5

test/org/apache/catalina/connector/TestRequest.java test/org/apache/catalina/startup/TestTomcat.java

Tomcat

Bug 47568 TestTomcat fails to delete work directory

TestTomcat.setUp() creates a work directory, but does not delete it in tearDown()

2009-07-23 12:56:58

resolved fixed

cfb18a0

test/org/apache/catalina/startup/TestTomcat.java

Tomcat

Bug 41824 Unable to use nested type in TLD

2007-03-12 10:40:25

resolved fixed

768af9f

java/org/apache/jasper/compiler/JspUtil.java

Tomcat

Bug 46907 Jasper with log4j in web-app classpath and debug level enabled prevents reading HTTP POST stream from JSP

This is on Tomcat 5.5.x (don't remember the last rev. number, not my current machine). When log4j is in the classpath of the web-app and is configured to log at debug level, Jasper dumps the whole HTTP POST request body as debug traces. This consumes the HttpServletRequest input stream which then arrives unusable for the user at the beginning of the JSP code (using HttpServletRequest.getInputStream(), the stream is already at its end). A workaround is to disable debug traces for Japser class in log4j.properties, but Jasper should not consume the HttpServletRequest input stream whatever mode it runs into.

2009-03-24 15:20:17

resolved fixed

50d0e6e

java/org/apache/jasper/servlet/JspServlet.java

Tomcat

Bug 47518 Valve Interface Javadocs for invoke method references non-existent method

It appears that the Valve interface javadoc hasn't been updated since around TC 5.5. Here is a snip of what it currently available from TC's website (6.0.20 I would guess): " # If the corresponding Response was not generated (and control was not returned, call the next Valve in the pipeline (if there is one) by executing context.invokeNext(). . . . # Modify the HTTP headers included with the Response after the invokeNext() method has returned. # Perform any actions on the output stream associated with the specified Response after the invokeNext() method has returned. " The invokeNext method has not existed in the Valve interface in many versions. I believe the replacement is: this.getNext().invoke(request, response) I'm happy to provide a doc patch if getNext().invoke(request, response) is the expected replacement for invokeNext(request, response). Note that the docs for 5.5 also have the same problem. Please let me know if I should log that separately.

2009-07-13 06:40:01

resolved fixed

9dc93f5

java/org/apache/catalina/Valve.java

Tomcat

Bug 41059 WebAppClassLoader clearReferences code break running threads

When the WebAppClassLoader stops it manually sets all static and final variables to null in the clearReferences method. This results in NPEs for any thread that was not stopped and not expecting its final or static variables to be null. This is particularly a problem with hot deploys since the unload fails and terminating the deploy.

2006-11-28 11:53:02

resolved fixed

a9f0239

java/org/apache/catalina/loader/WebappClassLoader.java

Tomcat

Bug 40551 Sticky sessions using PersistentManager enter indeterminate state on node failover

If a cluster of nodes is being load balanced with sticky sessions, and a particular node becomes unavailable, any sessions bound to that node must be redistributed. Particularly in the case of mod_jk these sessions will not be bound to whichever node the failover occurred on because the jessionid will still contain the JVM route of the original failed node, thus placing the session in an indeterminate state and losing sticky properties. I am attaching a patch that will trigger a session to rebind itself to a new node if the jvmroutes don't match and replace the jessionid in the browser's cookie.

2006-09-20 01:33:41

resolved fixed

f0d447d

java/org/apache/catalina/ha/session/JvmRouteBinderValve.java

Tomcat

Bug 47515 Tomcat can't replicate session when it is started.

2009-07-12 23:08:36

resolved fixed

83e98da

java/org/apache/catalina/ha/session/DeltaManager.java

Tomcat

Bug 40380 Potential syncro problem in StandardSession.expire(boolean)

public void expire(boolean notify) { // Mark this session as "being expired" if needed if (expiring) return; // No man's land here synchronized (this) { if (manager == null) return; expiring = true;

2006-08-31 18:57:30

resolved fixed

6f3e56e

java/org/apache/catalina/session/StandardSession.java

Tomcat

Bug 47524 McastServiceImpl executor is not dispatching events.

2009-07-14 06:20:02

resolved fixed

aa8a2d3

java/org/apache/catalina/tribes/membership/McastServiceImpl.java java/org/apache/catalina/tribes/transport/ReceiverBase.java java/org/apache/catalina/tribes/util/ExecutorFactory.java

Tomcat

Bug 39231 The JAAS contract for LoginModule is broken

The issue is that the custom JAAS's LoginModule.logout() method is never called. I guess this has been never implemented correctly (at least since Tomcat 5.5.9). The thing is that according to the JAAS spec, the LoginContext.logout() is supposed to invoke the logout method for each LoginModule configured for this LoginContext. So, somebody should be sure to call LoginContext.logout() method. The caller for this method could be either a server or a client. So, either Tomcat should provide some means to access the LoginContext to the clients, or Tomcat should take the responsibility to call this method by itself. I guess the solution could be for Tomcat to associate the instance of LoginContext with the user's session, and then Tomcat could invoke LoginContext.logout() when the session is being invalidated (both when the session times out or invalidated explicitely). I hope that I am correctly interpreting the JAAS spec.

2006-04-06 21:19:49

resolved fixed

80f8ec6

java/org/apache/catalina/realm/GenericPrincipal.java java/org/apache/catalina/realm/JAASRealm.java java/org/apache/catalina/session/StandardSession.java

Tomcat

Bug 47478 DeltaSession ignores notifyListenersOnReplication when BackupManager is used.

2009-07-06 03:05:17

resolved fixed

c1099f7

java/org/apache/catalina/ha/session/DeltaSession.java

Tomcat

Bug 37933 Bugs in Tomcat

2005-12-16 07:00:20

resolved fixed

202a33e

java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/compiler/PageInfo.java

Tomcat

Bug 37984 JNDIRealm.java not able to handle MD5 password

I'm using JNDIRealm to authenticate to OpenLDAP 2.2.28. Within OpenLDAP I've configured the userPassword attribute for each user to contain the MD5 digest, and each is prefixed with the string "{MD5}". I am not an LDAP expert by any means but I believe this prefix is a standard convention. Anyway assuming this is a convention then JNDIRealm needs to strip off the "{MD5}" portion much like it does with "{SHA1}". See attached patch which accomplishes this and I verified it works in my environment.

2005-12-21 05:51:20

resolved fixed

c6818a0

java/org/apache/catalina/realm/JNDIRealm.java

Tomcat

Bug 47440 Remove DB-specific SQL statements from test cases (SELECT 1)

Some of the test cases assume that the JDBC provider supports "SELECT 1" as a valid SQL statement; however this is not always the case, e.g. Derby requires a table name to select from. The solution provided in the patches is to use the validation query defined in the properties set up for the test, rather than always using "SELECT 1".

2009-06-27 05:17:55

resolved fixed

d92da6e

modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultProperties.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java

Tomcat

Bug 47439 PooledConnection.connect() fails to check for null connection

PooledConnection.connect() fails to check for null return from java.sql.Driver.connect() method. This can result in an NPE when the connection is used later.

2009-06-27 05:01:35

resolved fixed

ef96fa2

modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

Tomcat

Bug 38352 Additional Entries for Default catalina.policy file.

This patch adds additional entries to the catalina.policy file. Specifically: The catalina.base/shared directory is added and given equal permissions to catalina.home/common java.io.tmpdir is now readable. javax.servlet.context.tempdir is now readable. I think to be compliant with the spec, this must be allowed. Directory specified by java.io.tmpdir (which is what tomcat points javax.servlet.context.tempdir to) is now read, write, delete. Again, I think the spec requires this.

2006-01-22 20:27:46

resolved fixed

76a4eb3

java/org/apache/jasper/compiler/JspRuntimeContext.java

Tomcat

Bug 47308 Cannot join in the cluster membership.

2009-06-03 03:39:06

resolved fixed

51fd68b

java/org/apache/catalina/tribes/membership/McastService.java java/org/apache/catalina/tribes/membership/McastServiceImpl.java

Tomcat

Bug 47389 DeltaManager doesn't do the session replication. (notifySessionListenersOnReplication=false)

2009-06-18 03:39:55

resolved fixed

c768090

java/org/apache/catalina/ha/session/DeltaManager.java

Tomcat

Bug 47369 DeltaRequest is never reset. (use BackupManager)

2009-06-15 03:34:59

resolved fixed

b3e2be4

java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Tomcat

Bug 47343 Fails re-deploying, when we update context.xml.

2009-06-10 03:54:19

resolved fixed

cc1f0dd

java/org/apache/catalina/startup/HostConfig.java

Tomcat

Bug 47299 Cannot override StandardContext in embedding case because of StandardSession.fireContainerEvent

StandardSession.fireContainerEvent checks for the String class name! Why not just use an instanceof check here?

2009-06-02 07:19:36

resolved fixed

468f370

java/org/apache/catalina/session/StandardSession.java

Tomcat

Bug 47158 I think AccessLogValve has race condition problem

2009-05-05 15:12:45

resolved fixed

f00029e

java/org/apache/catalina/valves/AccessLogValve.java

Tomcat

Bug 47216 Possible NPE in Http11Processor.action()

The code at around line 1075: } else if (actionCode == ActionCode.ACTION_REQ_LOCAL_ADDR_ATTRIBUTE) { if (localAddr == null) localAddr = socket.getLocalAddress().getHostAddress(); fails to check if "socket != null". Since this is checked everywhere else in the method this is probably a bug. The method Http11Processor.parseHost() also references "socket" without checking for null. Within the class, it is only called by process(Socket), which guarantees that it won't be null. However once process() returns normally, socket will be set to null. The parseHost() method is public, so it may be called when socket == null. Perhaps the parseHost() method should be private?

2009-05-18 18:13:50

resolved wontfix

36feee0

java/org/apache/coyote/http11/Http11Processor.java

Tomcat

Bug 47234 serviceStartTime is different in MemberImpl from McastServiceImpl

Hi, I'm using the tribes cluster module in my own application (which has nothing to do with tomcat) and I'm using the member alive time value to sort all the cluster members. This bug produces the following: I have 2 nodes that were started almost at the same time and both nodes claim that the other node was started before them NODE1: Remote members: (-52.63.57.110:4001 ready=true suspect=false failing=false aliveTime=1526) Local member: (-52.63.57.109:4000 ready=true suspect=false failing=false aliveTime=1236) NODE2: Remote members: (-52.63.57.109:4000 ready=true suspect=false failing=false aliveTime=2021) Local member: (-52.63.57.110:4001 ready=true suspect=false failing=false aliveTime=1069) My code do the following: Member[] members = groupChannel.getMembers(); printRemote(members); Member localMember = groupChannel.getLocalMember(true); printLocal(localMember); In that code (due to timing issues) it should possible the other way around (that every node claim to be started before the other) but not that case. The issue occurs because when the McastService is started, it assigns a start time to the local member. public class McastService .... { public void start(int level) { .... localMember.setServiceStartTime(System.currentTimeMillis()); .... impl = new McastServiceImpl(localMember, ....); impl.start(level); } } But, then it creates and starts a McastServiceImpl which also stores a new serviceStartTime :-( public class McastServiceImpl { protected long serviceStartTime; public void start(int level) { .... serviceStartTime = System.currentTimeMillis(); .... } } So, we have 2 different start times. Unfortunately both times are used: To get the local member, the impl.getServiceStartTime() is used: public class McastService .... { public Member getLocalMember(boolean alive) { if ( alive && localMember != null && impl != null) localMember.setMemberAliveTime(System.currentTimeMillis()-impl.getServiceStartTime()); return localMember; } } But, when the member is transmited throw the network, the MemberImpl.getServiceStartTime() is used. public class MemberImpl .... { public byte[] getData(boolean getalive, boolean reset) { if ( reset ) dataPkg = null; //look in cache first if ( dataPkg!=null ) { if ( getalive ) { //you'd be surprised, but System.currentTimeMillis //shows up on the profiler long alive=System.currentTimeMillis()-getServiceStartTime(); XByteBuffer.toBytes( (long) alive, dataPkg, TRIBES_MBR_BEGIN.length+4); } return dataPkg; } ...... } That produces that weird behaviour. IMHO, the fix should be setting the same "serviceStartTime" to both components. This issue is affecting seriously my code. I would appreciate if you could fix it asap. I've verified that the same code is present in trunk repository. Regards, Ariel

2009-05-21 07:32:52

resolved fixed

9fa7640

java/org/apache/catalina/tribes/membership/McastServiceImpl.java

Tomcat

Bug 47111 do caching the resources like the docu say it (StringManager)

2009-04-28 08:54:49

resolved wontfix

96167ed

java/org/apache/tomcat/util/res/StringManager.java

Tomcat

Bug 47050 StandardHostValve.status unnecessarily HTML-escapes the error message

2009-04-19 01:59:15

resolved fixed

1ad0501

java/org/apache/catalina/core/StandardHostValve.java

Tomcat

Bug 47046 Shutdown does not unregister all MBeans

2009-04-17 07:59:51

resolved fixed

54b9da9

java/org/apache/catalina/connector/MapperListener.java java/org/apache/catalina/mbeans/MBeanUtils.java java/org/apache/catalina/mbeans/ServerLifecycleListener.java

Tomcat

Bug 46925 Nested groups in JNDI realm with non-recursive implementation

2009-03-27 03:58:28

resolved fixed

d04dd88

java/org/apache/catalina/realm/JNDIRealm.java

Tomcat

Bug 37929 invalidated session causes pageContext methods to fail

javax.servlet.http.HttpSession methods such as getAttribute(), getValue(), getAttributeNames(), getValueNames(), etc, throw an IllegalStateException if called on a session that has been invalidated. So, with the following code in a JSP page: <% session.invalidate(); Object obj = pageContext.findAttribute("foo"); %> An IllegalStateException is thrown because pageContext.findAttribute() eventually calls session.getAttribute() on a session that has been invalidated. The session that has been invalidated should simply be ignored when a method needs to process the various scopes (page, request, session, application). This impacts the following methods in PageContextImpl: public int getAttributesScope(final String name) which calls -> private int doGetAttributeScope(String name); public Object findAttribute(final String name) which calls -> private Object doFindAttribute(String name); public void removeAttribute(final String name) which calls -> private void doRemoveAttribute(String name); The fix is to catch IllegalStateException and ignore it when processing the attribute in session scope. The code then simply follows through to process application scope. No need to worry about setAttribute() because it is always invoked on a specific scope, and the spec already states that java.lang.IllegalStateException must be thrown when called on an invalidated session. pageContext.setAttribute("foo", "value of foo", PageContext.SESSION_SCOPE); java.lang.IllegalStateException - if the scope is PageContext.SESSION_SCOPE but the page that was requested does not participate in a session or the session has been invalidated. --------------------------------------------------------------------------- At the same time, a fix should be done to method "doRemoveAttribute(String name)" where a try/catch block for Exception appears unnecessary. private void doRemoveAttribute(String name){ try { removeAttribute(name, PAGE_SCOPE); removeAttribute(name, REQUEST_SCOPE); if( session != null ) { try { removeAttribute(name, SESSION_SCOPE); } catch (IllegalStateException ex) { // Session has been invalidated. // Ignore and fall through to application scope. } } removeAttribute(name, APPLICATION_SCOPE); } catch (Exception ex) { // we remove as much as we can, and // simply ignore possible exceptions } } Here is a full analysis: Starting with 'removeAttribute(final String name)' - we check for null and throw NPE if necessary - we call doRemoveAttribute(name) doRemoveAttribute(name) - we call removeAttribute(name, scope) for each scope removeAttribute(final String name, final int scope) - this calls doRemoveAttribute(name, scope) doRemoveAttribute(name, scope) - page scope: attributes.remove -> won't throw an Exception - request scope: request.removeAttribute -> no documented Exception thrown - session scope: throws IllegalStateException if session is null - app scope: context.removeAttribute -> no documented Exception thrown A null value for name is already checked in removeAttribute(final String name) and we throw NPE. So this situation (removing an attr from page or request scope throwing an NPE) won't happen. In doRemoveAttribute(name), we already check on session != null before calling removeAttribute(name, SESSION_SCOPE). So there normally is no IllegalStateException thrown (except for the invalidated case). When removing an attribute from application (i.e., ServletContext) scope, any registered listeners will be notified, but the code that does that (see appserv-webtier/src/java/org/apache/catalina/core/ApplicationContext. removeAttribute()) already catches any Throwable that a listener may throw. The try/catch block is therefore unnecessary. Moreover, if any of the removal actions from the different scopes could have thrown an exception, each of them would have needed to be wrapped inside their own try/catch, so as to ensure that an exception in one scope does not cause any of the subsequent removals to be bypassed. doRemoveAttribute(String name) has therefore been modified as follows: private void doRemoveAttribute(String name){ removeAttribute(name, PAGE_SCOPE); removeAttribute(name, REQUEST_SCOPE); if( session != null ) { try { removeAttribute(name, SESSION_SCOPE); } catch (IllegalStateException ex) { // Session has been invalidated. // Ignore and fall through to application scope. } } removeAttribute(name, APPLICATION_SCOPE); } -------------------------- Changes done on glassfish. ymmv on jasper for the diffs. --- PageContextImpl.java 9 Dec 2005 18:54:30 -0000 1.7 +++ PageContextImpl.java 16 Dec 2005 00:11:21 -0000 1.8 @@ -452,8 +452,13 @@ return REQUEST_SCOPE; if (session != null) { + try { if (session.getAttribute(name) != null) return SESSION_SCOPE; + } catch (IllegalStateException ex) { + // Session has been invalidated. + // Ignore and fall through to application scope. + } } if (context.getAttribute(name) != null) @@ -495,9 +500,14 @@ return o; if (session != null) { + try { o = session.getAttribute(name); - if (o != null) - return o; + } catch (IllegalStateException ex) { + // Session has been invalidated. + // Ignore and fall through to application scope. + } + + if (o != null) return o; } return context.getAttribute(name); @@ -559,19 +569,18 @@ } } - private void doRemoveAttribute(String name){ - try { removeAttribute(name, PAGE_SCOPE); removeAttribute(name, REQUEST_SCOPE); if( session != null ) { + try { removeAttribute(name, SESSION_SCOPE); + } catch (IllegalStateException ex) { + // Session has been invalidated. + // Ignore and fall through to application scope. } - removeAttribute(name, APPLICATION_SCOPE); - } catch (Exception ex) { - // we remove as much as we can, and - // simply ignore possible exceptions } + removeAttribute(name, APPLICATION_SCOPE); } public JspWriter getOut() {

2005-12-16 01:58:15

resolved fixed

04cacaf

java/org/apache/jasper/runtime/PageContextImpl.java

Tomcat

Bug 47013 JSP not compiled at startup when used as a servlet

2009-04-10 09:26:22

resolved fixed

c8cbc28

java/org/apache/catalina/core/Constants.java java/org/apache/catalina/core/StandardWrapper.java

Tomcat

Bug 42579 [Patch] JNDIRealm fails to parse absolute names

Active Directory can respond to a query with SearchResult's that are not relative. We discovered this happening with a directory hosted across many servers when the userBase was not sufficient to identify a single server. In getUserBySearch, JNDIRealm assumes that the SearchResult is relative and goes about creating a DN for the user by appending together the various bits of names it gets back. This is definitely wrong for absolute names which are URL's of the form: ldap://server/encoded_user_dn I discovered this issue in Tomcat 5.5 and a cursory look at the SVN repo for Tomcat 6.0 reveals that this bug is also present there. I have a patch for this issue which I will attach.

2007-06-04 14:13:14

resolved fixed

90e8d0d

java/org/apache/catalina/realm/JNDIRealm.java

Tomcat

Bug 46354 LIMIT_BUFFER setting causes arraycopy errors

2008-12-05 09:01:51

resolved fixed

78a994a

java/org/apache/jasper/runtime/BodyContentImpl.java

Tomcat

Bug 46984 Server incorrectly reports a 501 error on bad method name. Should report 400 error.

2009-04-07 07:44:46

resolved fixed

42a093b

java/org/apache/coyote/http11/Http11AprProcessor.java java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/coyote/http11/Http11Processor.java java/org/apache/coyote/http11/InternalAprInputBuffer.java java/org/apache/coyote/http11/InternalInputBuffer.java java/org/apache/coyote/http11/InternalNioInputBuffer.java

Tomcat

Bug 46961 org.apache.catalina.loader.WebappClassLoader throws exception related to Java 6 Bug 6434149

2009-04-03 07:15:39

resolved fixed

f109fb9

java/org/apache/catalina/loader/WebappClassLoader.java

Tomcat

Bug 46909 <jsp:plugin> error

<jsp:plugin type="applet"> generates type="application/x-java-applet;" instead of type = "application/x-java-applet". Firefox with Java-plugin cannot display Java applets because ";" is added.

2009-03-25 03:07:44

resolved fixed

80b90ee

java/org/apache/jasper/compiler/Generator.java

Tomcat

Bug 46562 Reader not closed

SHTML files are locked when using windows. Closing the reader solves the problem.

2009-01-19 08:17:14

resolved fixed

6ecc35d

java/org/apache/catalina/ssi/SSIServlet.java

Tomcat

Bug 46998 small fix to TaskThreadFactory

2009-04-08 11:35:20

resolved fixed

0c48c98

java/org/apache/tomcat/util/threads/TaskThreadFactory.java

Tomcat

Bug 46997 small fix to TaskQueue

2009-04-08 11:30:59

resolved fixed

4e1c4b2

java/org/apache/tomcat/util/threads/TaskQueue.java

Tomcat

Bug 46991 "Bytes received " problem

use jk module submit some data with post method ,but "Bytes received" always show zero see source file ,JkCoyoteHandler.java ,in "inovke" method public int invoke( Msg msg, MsgContext ep ) throws IOException { if( ep.isLogTimeEnabled() ) ep.setLong( MsgContext.TIMER_PRE_REQUEST, System.currentTimeMillis()); Request req=ep.getRequest(); Response res=req.getResponse(); if( log.isDebugEnabled() ) log.debug( "Invoke " + req + " " + res + " " + req.requestURI().toString()); res.setNote( epNote, ep ); ep.setStatus( MsgContext.JK_STATUS_HEAD ); RequestInfo rp = req.getRequestProcessor(); rp.setStage(Constants.STAGE_SERVICE); try { adapter.service( req, res ); } catch( Exception ex ) { log.info("Error servicing request " + req,ex); } if(ep.getStatus() != MsgContext.JK_STATUS_CLOSED) { res.finish(); } req.recycle(); req.updateCounters(); //see this line res.recycle(); ep.recycle(); if( ep.getStatus() == MsgContext.JK_STATUS_ERROR ) { return ERROR; } ep.setStatus( MsgContext.JK_STATUS_NEW ); rp.setStage(Constants.STAGE_KEEPALIVE); return OK; } the request object recycled,the "byteRead" property must be set to zero ,but at the next line ,begin to "updateCounters",this may be a bug

2009-04-08 01:37:54

resolved fixed

a228c06

java/org/apache/jk/server/JkCoyoteHandler.java

Tomcat

Bug 46990 Synchronize target can be changed midway

2009-04-07 18:52:10

resolved fixed

f1fd999

java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/StandardHost.java java/org/apache/catalina/tribes/membership/Membership.java java/org/apache/catalina/util/InstanceSupport.java java/org/apache/catalina/util/LifecycleSupport.java

Tomcat

Bug 46988 JMXAccessorTask String constants should be final

2009-04-07 17:18:48

resolved fixed

81ebe8f

java/org/apache/catalina/ant/jmx/JMXAccessorTask.java

Tomcat

Bug 46986 org.apache.jasper.Constants public arrays are mutable

There are various public String arrays in org.apache.jasper.Constants. Although the array variables are final, any code can change any of the array constants.

2009-04-07 17:14:51

resolved fixed

f497f12

java/org/apache/jasper/Constants.java java/org/apache/jasper/compiler/PageInfo.java java/org/apache/jasper/xmlparser/ParserUtils.java

Tomcat

Bug 46967 ManagerBase.setRandomFile error handling fix

On some platforms (z/OS for sure), the device file /dev/urandom can pass the "f.exists()" test, but throws an IOException of some kind when trying to open it. The current code in ManagerBase.setRandomFile() doesn't handle this, which results in EVERY call to getRandom() to try again and log the error "Failed to close randomIS". The following changes to the method will add proper error handling to correct this (my changes marked "// kjw") public void setRandomFile( String s ) { // as a hack, you can use a static file - and genarate the same // session ids ( good for strange debugging ) if (Globals.IS_SECURITY_ENABLED){ randomIS = (DataInputStream)AccessController.doPrivileged(new PrivilegedSetRandomFile()); } else { try{ devRandomSource=s; File f=new File( devRandomSource ); if( ! f.exists() ) return; randomIS= new DataInputStream( new FileInputStream(f)); randomIS.readLong(); if( log.isDebugEnabled() ) log.debug( "Opening " + devRandomSource ); } catch( IOException ex ) { log.debug("Error reading " + devRandomSource, ex); //kjw if (randomIS != null) { // kjw: if opened try { randomIS.close(); } catch (Exception e) { log.warn("Failed to close randomIS."); } } // kjw devRandomSource = null; // kjw: don't try again automatically randomIS=null; } } }

2009-04-03 18:57:28

resolved fixed

243aa86

java/org/apache/catalina/session/ManagerBase.java

Tomcat

Bug 46958 manager XML interface hard-coded path in XSL transformation

2009-04-02 16:55:36

resolved fixed

a9a58fb

java/org/apache/catalina/manager/Constants.java

Tomcat

Bug 46933 Using Java 1.5 in StringManager

2009-03-27 15:34:14

resolved fixed

23c47da

java/org/apache/tomcat/util/res/StringManager.java test/org/apache/tomcat/util/res/TestStringManager.java

Tomcat

Bug 46982 AccessLogValve reports correct time but incorrect offset following Spring DST transition.

This is a problem with AccessLogValve for tc5.5 as well as tc6.0 on all platforms. With the system clock on my linux machine (Ubuntu in my case) to just before the US time change on March 8, I started Tomcat 5.5 and see the following messages in my Tomcat access log after accessing Tomcat JSP example pages at the time of DST transition: -: - [08/Mar/2009:01:56:20 -0700] GET /jsp-examples/jsp2/simpletag/book.jsp HTTP/1.1 200 1738 1 - {http-8080-Processor24} -: - [08/Mar/2009:03:01:22 -0700] GET /jsp-examples/jsp2/tagfiles/hello.jsp HTTP/1.1 200 2213 68 - {http-8080-Processor25} Note the offset of "-0700" both before and after DST transition. Following a Tomcat restart the offset is correct: -: - [08/Mar/2009:03:19:42 -0600] GET /jsp-examples/jsp2/jspx/basic.jspx HTTP/1.1 200 1919 780 - {http-8080-Processor25} -: - [08/Mar/2009:03:19:59 -0600] GET /jsp-examples/jsp2/jspx/svgexample.html HTTP/1.1 200 2239 4 - {http-8080-Processor25} -: - [08/Mar/2009:03:19:59 -0600] GET /jsp-examples/jsp2/jspx/textRotate.jpg HTTP/1.1 200 26729 3 - {http-8080-Processor25} BTW, I ran the tzupdater before my tests: linwin01-512> java -jar tzupdater.jar -V tzupdater version 1.3.12-b01 JRE time zone data version: tzdata2009a Embedded time zone data version: tzdata2009a The problem is in the org.apache.catalina.valves.AccessLogValve which contains the following in its start method: // Initialize the timeZone, Date formatters, and currentDate timezone = TimeZone.getDefault(); timeZoneNoDST = calculateTimeZoneOffset(timezone.getRawOffset()); Calendar calendar = Calendar.getInstance(timezone); int offset = calendar.get(Calendar.DST_OFFSET); timeZoneDST = calculateTimeZoneOffset(timezone.getRawOffset()+offset); Based on what Ive seen, int offset = calendar.get(Calendar.DST_OFFSET); returns 0 when the current time is not in Daylight savings time and (for my timezone) 3600000 (60 * 60 * 1000) when the current time is in Daylight Savings. It looks like the code assumes this is always the offset for Daylight Savings for the current timezone. I have no idea if there are some locations/timezones where Daylight Savings Time does not have a 1 hour offset. Because of this, if in a non-DST time period, timeZoneDST and timeZoneNoDST are set to the same value. If in a DST time period, I believe they are set correctly so that the transition in Autumn works correctly. I think the only problem is when moving ahead in Springtime (unless the software has been running for 6 months or so which caused the offset to be set correctly).

2009-04-07 07:32:55

resolved fixed

360f8eb

java/org/apache/catalina/valves/AccessLogValve.java

Tomcat

Bug 41606 The jspInit method is called twice.

The problem is: The jspInit method is called twice. The definition is: -The JSP background compilations are enable. (In default web.xml, define checkInterval and define development false.) -Define the JSP with <servlet> and <load-on-startup> tag in web.xml. The proposing: org/apache/jasper/compiler/Compiler.java ---- public void compile(boolean compileClass, boolean jspcMode) throws FileNotFoundException, JasperException, Exception { .... if( compileClass ) { File targetFile = new File(ctxt.getClassFileName()); if (targetFile.exists()) { long targetLastModified = targetFile.lastModified(); if (jsw != null) { jsw.setServletClassLastModifiedTime(targetLastModified); } } } }// last of the method. ---- Regards, Yuichiro

2007-02-13 20:46:54

resolved fixed

f36a2c4

java/org/apache/jasper/compiler/Compiler.java

Tomcat

Bug 46822 Avoid redundant instantiations in StandardContext

2009-03-08 22:56:01

resolved fixed

b10d9da

java/org/apache/catalina/core/StandardContext.java

Tomcat

Bug 46866 Seed from current time is useless

fgrep -r 'new Random(System.currentTimeMillis())' . Gives 7 places where Random initialized with seed = currentTimeMillis. This is unnecessary, because better seed initialization happens in the default Random constructor.

2009-03-16 21:34:33

resolved fixed

fae26ce

java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/tribes/util/UUIDGenerator.java test/org/apache/catalina/tribes/demos/LoadTest.java test/org/apache/catalina/tribes/demos/MapDemo.java test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java test/org/apache/catalina/tribes/test/channel/TestRemoteProcessException.java test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java test/org/apache/catalina/tribes/test/io/TestSenderConnections.java

Tomcat

Bug 46875 CometConnectionManagerValve: concurrent access on session object when calling HttpSession.invalidate()

When calling invalidate() on an valid HttpSession object CometConnectionManagerValve methods sessionDestroy(HttpSessionEvent se) and event(Request request, Response response, CometEvent event) are called concurrently. So either a CometEvent with EventType.END and EventSubType.SESSION_END is never signaled via sessionDestroyed(...) or the HttpSession object has become invalid and the attribute holding comet requests can not be set or removed via event(...). I have configured CometConnectionManagerValve as a Valve element in context.xml and also as a Listener element in my applications web.xml. see this stacktrace 'sessionDestroy() was a bit faster': An exception or error occurred in the container during the request processing java.lang.IllegalStateException: removeAttribute: Session already invalidated at org.apache.catalina.session.StandardSession.removeAttribute(StandardSession.java:1206) at org.apache.catalina.session.StandardSession.removeAttribute(StandardSession.java:1181) at org.apache.catalina.session.StandardSessionFacade.removeAttribute(StandardSessionFacade.java:140) at org.apache.catalina.valves.CometConnectionManagerValve.event(CometConnectionManagerValve.java:335) at org.apache.catalina.core.StandardHostValve.event(StandardHostValve.java:179) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:200) at org.apache.catalina.core.StandardEngineValve.event(StandardEngineValve.java:128) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:198) at org.apache.coyote.http11.Http11NioProcessor.event(Http11NioProcessor.java:750) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.event(Http11NioProtocol.java:653) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2081) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907) at java.lang.Thread.run(Thread.java:637)

2009-03-19 02:15:04

resolved wontfix

08f7a5f

java/org/apache/catalina/valves/CometConnectionManagerValve.java

Tomcat

Bug 46666 Why is disableUploadTimeout and KeepAliveTimeout correlated in Http11 Connector?

In Http11Processor.java while (started && !error && keepAlive) { // Parsing the request header try { if (!disableUploadTimeout && keptAlive) { if (keepAliveTimeout > 0) { socket.setSoTimeout(keepAliveTimeout); } else if (soTimeout > 0) { socket.setSoTimeout(soTimeout); } } inputBuffer.parseRequestLine(); request.setStartTime(System.currentTimeMillis()); keptAlive = true; if (!disableUploadTimeout) { socket.setSoTimeout(timeout); } disableUploadTimeout - This flag allows the servlet container to use a different, longer connection timeout while a servlet is being executed, which in the end allows either the servlet a longer amount of time to complete its execution, or a longer timeout during data upload. If not specified, this attribute is set to "true". The code above is waiting on a new Http Request and precedes the servlet processing logic. It seems odd to me that I must set disableTimeout to false to get my keepAliveTimeout set. To set keepalivetimout, I must implicitely enable upload timeout whether I need it or not. It seems to me that the disableTimeout is unneccessary in the following line if (!disableUploadTimeout && keptAlive) { Do you agree with this? Thanks for the insight

2009-02-04 08:28:34

resolved fixed

ac6369a

java/org/apache/coyote/http11/Http11Processor.java

Tomcat

Bug 46696 Missing AL headers

The following files in tomcat-trunk don't have AL headers; as far as I can tell, they should: modules/jdbc-pool/sign.sh modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/StarvationTest.java

2009-02-11 09:41:23

resolved fixed

3b1b7b3

modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/StarvationTest.java

Tomcat

Bug 39396 OPTIONS request on directory with no default file reports an incorrect list of allowed HTTP verbs

When an "options" http request is made to Tomcat to a directory that has no default file (like index.jsp) in it, Tomcat reports a full list of allowed verbs, when in fact, most of them are NOT allowed. For example, a request to a generic img directory: OPTIONS /img/ HTTP/1.0 Cookie: JSESSIONID=C46C2E18BE95AD91828C9370CBDF0AF2 Content-Length: 0 Accept: */* Accept-Language: en-us Connection: Keep-Alive User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1 4322; InfoPath.1) Returns: HTTP/1.1 200 OK Server: Apache-Coyote/1.1 Allow: GET, HEAD, POST, PUT, DELETE, TRACE, OPTIONS Content-Length: 0 Date: Mon, 24 Apr 2006 15:11:16 GMT Connection: close Which shows several destructive options available (PUT, DELETE). But a request to DELETE or PUT (correctly) returns a 403 FORBIDDEN result: DELETE /img/ HTTP/1.0 Cookie: JSESSIONID=C46C2E18BE95AD91828C9370CBDF0AF2 Content-Length: 0 Accept: */* Accept-Language: en-us Connection: Keep-Alive User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1 4322; InfoPath.1) Returns: HTTP/1.1 403 Forbidden Server: Apache-Coyote/1.1 Content-Type: text/html;charset=utf-8 Content-Length: 964 Date: Mon, 24 Apr 2006 15:12:31 GMT Connection: close Because the initial OPTIONS request returns a list containing dangerous verbs, the directory will be flagged as a serious security vulnerability by most scanners (a false positive). The issue DOES NOT occur when the directory HAS a default file in it: OPTIONS /user_management/ HTTP/1.0 Cookie: JSESSIONID=C46C2E18BE95AD91828C9370CBDF0AF2 Content-Length: 0 Accept: */* Accept-Language: en-us Connection: Keep-Alive User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1 4322; InfoPath.1) Returns: HTTP/1.1 200 OK Server: Apache-Coyote/1.1 Set-Cookie: JSESSIONID=BC992F0C86E2BCBD0A2E5F1B3A12C50C; Path=/ Content-Type: text/html;charset=ISO-8859-1 Date: Mon, 24 Apr 2006 15:14:27 GMT Connection: close

2006-04-24 15:15:57

resolved fixed

9752018

java/org/apache/catalina/connector/RequestFacade.java java/org/apache/catalina/servlets/DefaultServlet.java

Tomcat

Bug 38570 if docBase path contains "webapps", a backslash is inserted

2006-02-08 15:46:45

resolved fixed

8d2b8ff

java/org/apache/catalina/startup/ContextConfig.java

Tomcat

Bug 38553 Wrong HTTP code for failed CLIENT-CERT authentication

server.xml: =========== I set clientAuth to "want" tomcat-user.xml: ================ I create a role and an user with the ssl certificate metadata web.xml: ======== For a private URL on my webseite, I create a security constraint like this one: <security-constraint> <web-resource-collection> <web-resource-name>App</web-resource-name> <url-pattern>/protected.jsp</url-pattern> </web-resource-collection> <auth-constraint> <role-name>tomcat</role-name> </auth-constraint> <user-data-constraint> <transport-guarantee>CONFIDENTIAL</transport-guarantee> </user-data-constraint> </security-constraint> <login-config> <auth-method>CLIENT-CERT</auth-method> </login-config> <security-role> <role-name>tomcat</role-name> </security-role> My results: (I try to access the restricted JSP-Page) =========== 1) When there is the RIGHT client certificate in the browser keystore: it works :-) 2) When there is the WRONG client certificate I get: HTTP Status 401 - Cannot authenticate with the provided credentials (this is ok, too) 3) When there is NO client certificate I get: HTTP Status 400 - No client certificate chain in this request 400 usually stands for a bad request or bad syntax. The Bug: ======== In case 3 I expect to get HTTP Status 401.

2006-02-07 16:54:17

resolved fixed

156f1ca

java/org/apache/catalina/authenticator/SSLAuthenticator.java

Tomcat

Bug 38197 taglib pool bug when tag is used with jsp:attribute

2006-01-09 15:53:09

resolved fixed

2824a70

java/org/apache/jasper/compiler/Generator.java

Tomcat

Bug 46606 WebdavServlet

2009-01-26 07:18:21

resolved fixed

f0bd732

java/org/apache/catalina/servlets/WebdavServlet.java

Tomcat

Bug 46564 .tagx files don't compile if the document and page encoding casing differs

2009-01-20 00:34:11

resolved fixed

7d7f757

java/org/apache/jasper/compiler/Validator.java

Tomcat

Bug 46471 Compiled tag files from different tag libraries share the same package

2009-01-04 16:12:40

resolved fixed

3aaac85

java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java java/org/apache/jasper/compiler/JspUtil.java java/org/apache/jasper/compiler/ParserController.java java/org/apache/jasper/compiler/TagFileProcessor.java java/org/apache/jasper/compiler/TagLibraryInfoImpl.java

Tomcat

Bug 46462 JSPWiki JSP compilation prevented by org.apache.jasper.Constants.JSP_PACKAGE_NAME

2009-01-01 20:29:15

resolved fixed

1ca03ff

java/org/apache/jasper/servlet/JasperLoader.java

Tomcat

Bug 46298 JDBCRealm.open() throws NullPointerException if the specified driver doesn't handle the specified JDBC URL

2008-11-25 23:25:56

resolved fixed

e31998a

java/org/apache/catalina/realm/JDBCRealm.java

Tomcat

Bug 46261 Context with %2F in name causes tomcat crash on shutdown

Context with %2F in name causes tomcat crash on shutdown Several years ago I worked on integrating tomcat 5.5 into our web application management infrastructure. During the process I fixed several tomcat 5.5 bugs, but apparently never sent the fixes upstream. Oops. Our application needs to be deployed to create a URL that looks like this: /product/customername/servlet I worked with several people on IRC to get tomcat5.5 to do this. We had previously been using the path= parameter in the context xml file element with tomcat 4.1. Unfortunately, it appears this feature was removed from tomcat5.5, and tomcat5.5 does not recurse into subdirectories when reading .xml context files. The recommendation on IRC (after several suggestions which would not work for our environment) was to put %2F in the context xml file's name. Such as this product%2Fcustomername.xml This does work, however when you try to shutdown tomcat 6.0.18, you will get this crash: Nov 9, 2008 10:56:17 PM org.apache.coyote.http11.Http11Protocol pause INFO: Pausing Coyote HTTP/1.1 on http-8180 Nov 9, 2008 10:56:18 PM org.apache.catalina.core.StandardService stop INFO: Stopping service Catalina Nov 9, 2008 10:56:18 PM org.apache.catalina.startup.HostConfig undeployApps WARNING: Error while removing context [/product%2Fcustomername] java.lang.NullPointerException at org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:915) at org.apache.catalina.startup.HostConfig.undeployApps(HostConfig.java:1191) at org.apache.catalina.startup.HostConfig.stop(HostConfig.java:1162) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:313) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:117) at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1086) at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1098) at org.apache.catalina.core.StandardEngine.stop(StandardEngine.java:448) at org.apache.catalina.core.StandardService.stop(StandardService.java:584) at org.apache.catalina.core.StandardServer.stop(StandardServer.java:744) at org.apache.catalina.startup.Catalina.stop(Catalina.java:628) at org.apache.catalina.startup.Catalina$CatalinaShutdownHook.run(Catalina.java:671) Nov 9, 2008 10:56:18 PM org.apache.coyote.http11.Http11Protocol destroy INFO: Stopping Coyote HTTP/1.1 on http-8180

2008-11-21 08:34:21

resolved fixed

85fc30c

java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/manager/HTMLManagerServlet.java

Tomcat

Bug 46381 Coerce EL expression to java.lang.Object breaks expression concatenation

2008-12-11 07:13:00

resolved fixed

24bcb47

java/org/apache/jasper/compiler/Generator.java

Tomcat

Bug 46357 FarmWarDeployer has nonsense condition

FarmWarDeployer has the following code at line 152: if(econtainer == null && econtainer instanceof Engine) { There's clearly something wrong with that condition.

2008-12-06 05:48:33

resolved fixed

7e6a2ec

java/org/apache/catalina/ha/deploy/FarmWarDeployer.java

Tomcat

Bug 46397 Potential memory leak with TagHandlers and JspIdConsumer

2008-12-15 00:43:53

resolved fixed

5277185

java/org/apache/jasper/compiler/Generator.java

Tomcat

Bug 46403 Persistent cookies written by 6.0.18 do not work in Internet Explorer or Safari

2008-12-15 13:46:47

resolved fixed

99c5ca6

java/org/apache/tomcat/util/http/ServerCookie.java

Tomcat

Bug 46408 Invalid cast in SecurityUtil

In case of PrivilegedActionException thrown in: private static void execute(final Method method, final Object targetObject, final Object[] targetArguments, Principal principal) method, there is a false assumption in catch block, that PrivilegedActionException.getException() will return InvocationTargetException. It could be also IllegalAccessException and possibly other types of exceptions as well. Here is the stack trace provoked on catalina shutdown when enabled security manager: java.lang.ClassCastException: java.lang.IllegalAccessException cannot be cast to java.lang.reflect.InvocationTargetException at org.apache.catalina.security.SecurityUtil.execute(SecurityUtil.java:278) at org.apache.catalina.security.SecurityUtil.doAsPrivilege(SecurityUtil.java:218) at org.apache.catalina.security.SecurityUtil.doAsPrivilege(SecurityUtil.java:178) at org.apache.catalina.core.ApplicationFilterConfig.release(ApplicationFilterConfig.java:326) at org.apache.catalina.core.StandardContext.filterStop(StandardContext.java:3744) at org.apache.catalina.core.StandardContext.stop(StandardContext.java:4513) at org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:924) at org.apache.catalina.startup.HostConfig.undeployApps(HostConfig.java:1191) at org.apache.catalina.startup.HostConfig.stop(HostConfig.java:1162) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:313) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:117) at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1086) at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1098) at org.apache.catalina.core.StandardEngine.stop(StandardEngine.java:448) at org.apache.catalina.core.StandardService.stop(StandardService.java:584) at org.apache.catalina.core.StandardServer.stop(StandardServer.java:744) at org.apache.catalina.startup.Catalina.stop(Catalina.java:628) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.stop(Bootstrap.java:300) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.commons.daemon.support.DaemonLoader.stop(DaemonLoader.java:200)

2008-12-16 15:22:51

resolved fixed

a1e4c86

java/org/apache/catalina/security/SecurityUtil.java

Tomcat

Bug 46247 SVN property patches

2008-11-19 18:16:54

resolved fixed

408175f

modules/bayeux/java/org/apache/cometd/bayeux/Bayeux.java modules/bayeux/java/org/apache/cometd/bayeux/Channel.java modules/bayeux/java/org/apache/cometd/bayeux/Client.java modules/bayeux/java/org/apache/cometd/bayeux/DataFilter.java modules/bayeux/java/org/apache/cometd/bayeux/Listener.java modules/bayeux/java/org/apache/cometd/bayeux/Message.java modules/bayeux/java/org/apache/cometd/bayeux/SecurityPolicy.java modules/bayeux/java/org/apache/tomcat/bayeux/BayeuxException.java modules/bayeux/java/org/apache/tomcat/bayeux/BayeuxRequest.java modules/bayeux/java/org/apache/tomcat/bayeux/BayeuxServlet.java modules/bayeux/java/org/apache/tomcat/bayeux/ChannelImpl.java modules/bayeux/java/org/apache/tomcat/bayeux/ClientImpl.java modules/bayeux/java/org/apache/tomcat/bayeux/HttpError.java modules/bayeux/java/org/apache/tomcat/bayeux/MessageImpl.java modules/bayeux/java/org/apache/tomcat/bayeux/RequestBase.java modules/bayeux/java/org/apache/tomcat/bayeux/RequestFactory.java modules/bayeux/java/org/apache/tomcat/bayeux/TomcatBayeux.java modules/bayeux/java/org/apache/tomcat/bayeux/request/MetaConnectRequest.java modules/bayeux/java/org/apache/tomcat/bayeux/request/MetaDisconnectRequest.java modules/bayeux/java/org/apache/tomcat/bayeux/request/MetaHandshakeRequest.java modules/bayeux/java/org/apache/tomcat/bayeux/request/MetaSubscribeRequest.java modules/bayeux/java/org/apache/tomcat/bayeux/request/MetaUnsubscribeRequest.java modules/bayeux/java/org/apache/tomcat/bayeux/request/PublishRequest.java modules/bayeux/test/org/apache/cometd/bayeux/samples/BayeuxStockTicker.java modules/bayeux/test/org/apache/cometd/bayeux/samples/EchoChatClient.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java

Tomcat

Bug 42077 the iterator from javax.el.CompositeELResolver#getFeatureDescriptor() must not return null values

2007-04-10 03:03:51

resolved fixed

8d5db6f

java/javax/el/CompositeELResolver.java

Tomcat

Bug 42693 JSP-Generation error with recursive tagfile structure

addendum: it's Version 6.13 (not available in combobox above) scenario: ========= a menu is decribed by a tree structure; rendering the menu is done by a tagfile 'render_menuitem', which renders the current item either as a leaf item (clicking on it causes an action) or as a node item (clicking on it opens another next-level submenu); rendering the submenu is done by calling the tagfile again from within its body; this worked fine with tomcat 5.0.x and 5.5.x to make it clear see the following pseudo code (the original code is to voluminous): tagfile 'render_menuitem.tagx': <jsp:root ...> <jsp:directive.attribute name="menu_item"/> <c:choose> <c:when test="${menu_item.isNode} <div>node: ${menu_item.label}</div> <c:forEach var="sub_item" items="menu_item.children"> <!-- THIS IS GOING TO CAUSE THE PROBLEM WITH TOMCAT6: --> <tags:render_menuitem menu_item="${sub_item}"/> </c:forEach> <c:when> <c:otherwise> <div>leaf: ${menu_item.label}</div> </c:otherwise> </c:choose> </jsp:root> faulty behaviour: ================ with tomcat 6.0.13, the generated Java-Source for the tagfile reveals, that the body of the doTag() method is empty and therefore emits no html; the compilation itself was silently done, no error or warning was shown in the logfiles.

2007-06-18 10:10:02

resolved fixed

b5a5094

java/org/apache/jasper/compiler/Compiler.java

Tomcat

Bug 42707 add host alias using jmx doesn't take affect until restart

2007-06-20 14:46:49

resolved fixed

23a8ba0

java/org/apache/catalina/connector/MapperListener.java java/org/apache/tomcat/util/http/mapper/Mapper.java

Tomcat

Bug 42673 SSI virtual include broken for context path with slashes

If the context path of an application contains slashes (e.g. "a/b") the method getPathWithoutContext of class org.apache.catalina.ssi.SSIServletExternalResolver simply cuts from the second slash, so for url "/a/b/do?.." it tries to include "b/do?.." instead of "do?..". The patch is to include the context path and strip the path off: Line 419 String noContext = getPathWithoutContext(normContext.getContextPath(), normalized); Line 356ff protected String getPathWithoutContext(final String contextPath, final String servletPath) { if (servletPath.startsWith(contextPath)) { return servletPath.substring(contextPath.length()); } return servletPath; }

2007-06-15 05:08:34

resolved fixed

4d5cca1

java/org/apache/catalina/ssi/SSIServletExternalResolver.java

Tomcat

Bug 46011 Cannot access to Principal via Subject.getSubject(AccessController.getContext())

Cannot access to Principal via Subject.getSubject(AccessController.getContext()). Problem is that in method internalDoFilter of ApplicationFilterChain in call of filter chain the code determinate the Principal but don't use it: if( Globals.IS_SECURITY_ENABLED ) { final ServletRequest req = request; final ServletResponse res = response; Principal principal = ((HttpServletRequest) req).getUserPrincipal(); Object[] args = new Object[]{req, res, this}; SecurityUtil.doAsPrivilege ("doFilter", filter, classType, args); args = null; } else { In this manner a SecurityUtil.doAsPrivilege will be called with Principal == null and method execute create a Subject with no Principals. Then call a Subject.doAsPrivileged(subject, pea, null); and this do not propagate Principals. I obtain a Subject without Principals calling Subject.getSubject(AccessController.getContext()). In attachment we send our solution

2008-10-15 02:56:56

resolved fixed

e148369

java/org/apache/catalina/core/ApplicationFilterChain.java java/org/apache/catalina/security/SecurityUtil.java

Tomcat

Bug 46047 Issue when using include directive inside tag files that are inside jar files

2008-10-21 02:20:44

resolved fixed

38ef38d

java/org/apache/jasper/compiler/ParserController.java

Tomcat

Bug 42409 Extra response headers not sent when using custom error page

If I create a servlet that does the following: response.setHeader("X-BUG", "Value"); response.sendError(HttpServletResponse.SC_BAD_REQUEST); If I use the tomcat default error page for 400 responses, the response will contain the header "X-BUG" with value "Value". However, if I create a custom error page, the response headers do NOT contain the "X-BUG" header in the response. Here is my web.xml, for example: <error-page> <error-code>400</error-code> <location>/400.jsp</location> </error-page> 400.jsp contains plain html: <html> <body> <h3>Custom 400 error page</h3> </body> </html>

2007-05-14 09:03:17

resolved fixed

e0489c8

java/org/apache/catalina/core/StandardHostValve.java

Tomcat

Bug 46051 Servlet response writer does not respect line.separator system property

2008-10-21 10:54:42

resolved fixed

f4bef20

java/org/apache/catalina/connector/CoyoteWriter.java

Tomcat

Bug 46105 URIEncoding doesn't affect after form-authentication redirect

How to reproduce bug. Configure tomcat connector with URIEncoding=UTF-8 attribute. Make a simple page that write out any request parameter. Configure this page as protected with form-based authentication. Try to access page, e.g. /site/page.jsp?q=%xx%yy%zz%tt where q=%xx%yy%zz is value in UTF-8 charset. When page is being accessed for the first time, then after authentication, parameter "q" is incorrectly interpreted (it seems as it was in ISO8859-1 or anything else, but not UTF-8). But subsequent access to the _same_ URI, i.e. /site/page.jsp?q=%xx%yy%zz%tt gives perfect result. I also tried useBobyEncodingForURI=true and request.setCharacterEncoding("UTF-8") - nothing is changed.

2008-10-27 23:37:52

resolved fixed

d9def07

java/org/apache/catalina/authenticator/FormAuthenticator.java

Tomcat

Bug 46075 FileUpload memory usage

The DefaultFileItem class in pacakge org.apache.tomcat.util.http.fileupload creates a ByteArrayOutputStream of the full threshold size for every control on the submitted form. I have a form with 63 controls (checkboxes, text boxes and one File input), and I set the threshold to 20 Meg to allow upload of large image files into memory. I get an OutOfMemory exception since it tries to allocate 63 lots of 20M, although only 1 control requires the requested size. I think it would be much more sensible to create the ByteArrayOutputStream with an initial size of only a few kilobytes size it automatically increases its size as data is written to it.

2008-10-23 03:35:53

resolved fixed

85e71cf

java/org/apache/tomcat/util/http/fileupload/DeferredFileOutputStream.java

Tomcat

Bug 46085 Session are incorrectly expired due to thread unsafe code

2008-10-24 12:53:09

resolved fixed

6344b96

java/org/apache/catalina/session/StandardSession.java

Tomcat

Bug 46096 DefaultAnnotationProcessor.processAnnotations should use doPrivileged to call getDeclaredFields

If tomcat is running with a SecurityManager, and a JSP uses PageContext.forward, DefaultAnnotationProcessor code can be called with untristed code on the call stack. The processAnnotations method contains the line: Field[] fields = instance.getClass().getDeclaredFields(); getDeclaredFields() is subject to security checks so this throws a java.security.AccessControlException. DefaultAnnotationProcessor is part of the code in the catlina lib directory, which is granted AllPermissions in the standard policy file. However, because there is untrusted JSP code on the stack, these permissions are not used. The call to getDeclaredFields() should be wrapped in an AccessController.doPrivileged call to avoid the exception.

2008-10-27 05:44:55

resolved fixed

428c03b

java/org/apache/catalina/core/DefaultInstanceManager.java

Tomcat

Bug 45735 Updated ResourceAttributes.getETag

After looking at a user's list post, I noticed the implementation was not consistent with the other getters (like getName). I propose changing it to: public String getETag(boolean strong) { if (strong) { // The strong ETag must always be calculated by the resources if (strongETag != null) return strongETag; if (attributes != null) { Attribute attribute = attributes.get(ETAG); if (attribute != null) { try { strongETag = attribute.get().toString(); } catch (NamingException e) { ; // No value for the attribute } } } return strongETag; } else { // The weakETag is contentLenght + lastModified if (weakETag == null) { weakETag = "W/\"" + getContentLength() + "-" + getLastModified() + "\""; } return weakETag; } }

2008-09-03 10:48:23

resolved fixed

e40c910

java/org/apache/naming/resources/ResourceAttributes.java

Tomcat

Bug 45977 Duplicate comment in code - CoyoteAdapter.java

The XXX comments below seem to say the same thing. Not sure what the XXX represents. /** * Parse additional request parameters. */ protected boolean postParseRequest(org.apache.coyote.Request req, Request request, org.apache.coyote.Response res, Response response) throws Exception { // XXX the processor needs to set a correct scheme and port prior to this point, // in ajp13 protocols dont make sense to get the port from the connector.. // XXX the processor may have set a correct scheme and port prior to this point, // in ajp13 protocols dont make sense to get the port from the connector... // otherwise, use connector configuration if (! req.scheme().isNull()) { // use processor specified scheme to determine secure state request.setSecure(req.scheme().equals("https"));

2008-10-09 08:28:02

resolved fixed

e277f6c

java/org/apache/catalina/connector/CoyoteAdapter.java

Tomcat

Bug 45951 Provide support for renaming JSESSIONID

2008-10-05 15:15:52

resolved fixed

e85ed8c

java/org/apache/catalina/Globals.java java/org/apache/catalina/authenticator/Constants.java java/org/apache/jasper/Constants.java

Tomcat

Bug 45933 Error processing TLD file in webapp with XML parser

2008-10-01 23:51:18

resolved fixed

f69637f

java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java

Tomcat

Bug 45851 FarmWarDeployer fails to properly unpack copied war on target node

2008-09-19 22:17:57

resolved fixed

c340c69

java/org/apache/catalina/ha/deploy/FarmWarDeployer.java java/org/apache/catalina/ha/deploy/FileMessageFactory.java

Tomcat

Bug 45026 Custom HTTP-Error codes get remapped to 500er codes

We use Apache 2.2.8 with mod_JK 1.2.26 as a load-balancer for a Tomcat 5.5 cluster. We use Custom HTTP-Error codes like 450 for authentication-purposes. Those codes get remapped to 500. The Error-Code 450 is in the RFC2616 described as valid return code so this is a bug. The custom error-codes worked fine in Apache 1.3.41 with MOD_JK/1.2.25. You can easily reproduce this bug by writing a simple jsp-page with the following line: <%response.setStatus(450);%>

2008-05-18 04:16:12

resolved fixed

03097fa

java/org/apache/jk/common/JkInputStream.java

Tomcat

Bug 45419 Return Accept-Ranges from DefaultServlet

Currently the DefaultServlet accepts the "Ranges" request header, but doesn't indicate this in its response by returning "Accept-Ranges: bytes". Although this is not required in HTTP/1.1, setting the header is required in order for the Adobe Acrobat plugin to correctly handle Linearized PDF's (which can speed download by allowing random access to a PDF file). Although it's not strictly necessary according to the specification I can't think of any reason why this header is not safe to set in a response from DefaultServlet, which is always dealing with static files, and not doing so has a negative impact on serving large PDF files - so I'm filing it as a bug rather than an RFE.

2008-07-17 07:38:07

resolved fixed

633545f

java/org/apache/catalina/servlets/DefaultServlet.java

Tomcat

Bug 45441 Matching of relevant servlet filters fails when request is forwarded...

I ran into a situation where Tomcat will not execute appropriate filters on a request that has been forwarded. I'm using the handy URLRewriteFilter implementation (from tuckey.org). When I forwarded a request internally, filters that had a matching url-pattern (in the web.xml file) and with a dispatcher setting of both REQUEST and FORWARD were not invoked. On tracing the code (hours later), I found that the problem lies inside the ApplicationDispatcher code. It set the DISPATCHER_REQUEST_PATH_ATTR state attribue to be the servletPath. That meant that only matches using the servlet path would match, but longer (more exact) urls would fail to match. For example, using the following filter mapping: <filter-mapping> <filter-name>my-filter</filter-name> <url-pattern>/app/level/mycode.do</url-pattern> <dispatcher>REQUEST</dispatcher> <dispatcher>FORWARD</dispatcher> </filter-mapping> would not match a request that was forwarded to /app/level/mycode.do, which it should! Changing the url pattern to be "/app/*" would match, but "/app/level/*" would not, since the servletPath was /app in this example. The fix for this is quite simple. In the ApplicationDispatcher.java code, in the method processRequest() (which is only called for forwards), change the following statement: state.outerRequest.setAttribute (ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR, servletPath); to use requestURI instead as follows: state.outerRequest.setAttribute (ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR, requestURI ); This resolves the problem and let all the examples above correctly match and run the filter on a forward. I believe includes will also be broken in the same manner. Similar changes to the doInclude() method in ApplicationDispatcher.java will likely resolve that issue as well, though I have not tested this personally. Be nice to see this resolved in 6.0.17+. Thanks! ....Andrzej

2008-07-20 10:54:40

resolved fixed

2c0fffe

java/org/apache/catalina/core/ApplicationDispatcher.java

Tomcat

Bug 45823 AccessLogValve doesn't correctly handles combined log format (with patch)

2008-09-17 02:20:05

resolved fixed

678b516

java/org/apache/catalina/valves/AccessLogValve.java

Tomcat

Bug 45618 Selector is not closed.

2008-08-11 22:45:15

resolved fixed

d69b378

java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java

Tomcat

Bug 45413 Contribution of Bayeux implementation for Tomcat

2008-07-16 17:49:44

resolved fixed

83fe69a

java/org/apache/cometd/bayeux/Bayeux.java java/org/apache/cometd/bayeux/Channel.java java/org/apache/cometd/bayeux/Client.java java/org/apache/cometd/bayeux/DataFilter.java java/org/apache/cometd/bayeux/Listener.java java/org/apache/cometd/bayeux/Message.java java/org/apache/cometd/bayeux/SecurityPolicy.java java/org/apache/tomcat/bayeux/BayeuxException.java java/org/apache/tomcat/bayeux/BayeuxRequest.java java/org/apache/tomcat/bayeux/BayeuxServlet.java java/org/apache/tomcat/bayeux/ChannelImpl.java java/org/apache/tomcat/bayeux/ClientImpl.java java/org/apache/tomcat/bayeux/HttpError.java java/org/apache/tomcat/bayeux/MessageImpl.java java/org/apache/tomcat/bayeux/RequestBase.java java/org/apache/tomcat/bayeux/RequestFactory.java java/org/apache/tomcat/bayeux/TomcatBayeux.java java/org/apache/tomcat/bayeux/request/MetaConnectRequest.java java/org/apache/tomcat/bayeux/request/MetaDisconnectRequest.java java/org/apache/tomcat/bayeux/request/MetaHandshakeRequest.java java/org/apache/tomcat/bayeux/request/MetaSubscribeRequest.java java/org/apache/tomcat/bayeux/request/MetaUnsubscribeRequest.java java/org/apache/tomcat/bayeux/request/PublishRequest.java test/org/apache/cometd/bayeux/samples/EchoChatClient.java

Tomcat

Bug 45628 ExtensionValidator doesn't handle wrapped lines in MANIFEST.MF

2008-08-13 12:47:56

resolved fixed

3773ec4

java/org/apache/catalina/util/ManifestResource.java

Tomcat

Bug 45666 JspContextWrapper contains infinite loop in include(String relativeUrlPath, boolean flush)

public void include(String relativeUrlPath, boolean flush) throws ServletException, IOException { include(relativeUrlPath, false); // XXX } just calls itself it seems. Perhaps this should be (just a guess): public void include(String relativeUrlPath, boolean flush) throws ServletException, IOException { invokingJspCtxt.include(relativeUrlPath, false); // XXX } This came up for me when I had a .tag file that had an include in it. I was using Tomcat 5.5 but looking at the source of JspContextWrapper.java it looks like this issue is in 5.5 as well as 6 (and the svn trunk).

2008-08-21 06:47:17

resolved fixed

ccc1014

java/org/apache/jasper/runtime/JspContextWrapper.java

Tomcat

Bug 45648 Function 'f:length' not found

2008-08-18 19:54:44

resolved fixed

6d40691

java/org/apache/el/parser/ELParser.java

Tomcat

Bug 45691 Jasper creates duplicate variable names

Sometimes a JSP's Java code, which have been generated by Jasper, has duplicate variable names. Therefore the JSP cannot be compiled and tomcat delivers an HTTP status code 500. You get an error message like this org.apache.jasper.JasperException: Unable to compile class for JSP: An error occurred at line: 10 in the jsp file: /test1.jsp Duplicate local variable _jspx_temp0 7: <c:set var="a"> 8: <jsp:attribute name="value"><%= new java.util.Date().toString() %></jsp:attribute> 9: </c:set> 10: <c:set var="b"> 11: <jsp:attribute name="value"><%= new java.util.Date().toString() %></jsp:attribute> 12: </c:set> 13: <h1>Test 1</h1> The reason of this error is the generation of variable names like _jspx_temp0, which are created for <jsp:attribute> tags. At the beginning of parsing a JSP file a counter is reset to 0. Every time an <jsp:attribute> tag occurs, the counter is used to build a variable name _jspx_temp<counter>. Thereafter the counter will be incremented. Unfortunately the counter is a static member of the JspUtil class. Suppose there's a thread 1, which created _jspx_temp4. The counter is 5. Now a second thread (thread 2) starts and resets the counter. Afterwards thread 2 creates _jspx_temp0 to _jspx_temp3. The counter is 4 by now. Then thread 2 stops and thread 1 continues. The next variable's name in thread 1 will be _jspx_temp4, which already exists. Therefore the generated java class cannot be compiled.

2008-08-26 07:23:33

resolved fixed

337d6a6

java/org/apache/jasper/compiler/Compiler.java java/org/apache/jasper/compiler/JspUtil.java java/org/apache/jasper/compiler/Node.java java/org/apache/jasper/compiler/TagPluginManager.java

Tomcat

Bug 45074 Add configuration parameters for finer tuning of Http11AprProtocol thread usage

2008-05-23 15:44:19

resolved fixed

6a1f316

java/org/apache/coyote/http11/Http11AprProtocol.java

Tomcat

Bug 44809 Improve AprLifecycleListener Error Messages

2008-04-11 10:18:59

resolved fixed

46055c5

java/org/apache/catalina/core/AprLifecycleListener.java

Tomcat