Parameterize test data (#116)

.github/workflows/ci-cd.yaml

@@ -160,7 +160,7 @@ jobs:
       - name: Install dependencies
         run: pip3 install -r requirements.txt
       - name: Run acceptance tests
-        run: behave
+        run: behave -v
       - name: Copy over data onto host
         run: docker cp data-loader:/data .
       - name: Test image build
@@ -191,7 +191,7 @@ jobs:
           readme-filepath: README.md
 
   triggering:
-    name: Triggering data model acceptance tests CI/CD
+    name: Triggering data loader CI/CD
     needs: [sync-to-huggingface-space, docker]
     if: github.ref == 'refs/heads/master'
     runs-on: ubuntu-latest

features/graphs.feature

@@ -13,6 +13,10 @@
 # limitations under the License.
 Feature: Neo4J in Docker shows expected graphs
 
-  Scenario: "but" linking
-      When we expand 'δέ' by 3 hops at most
-      Then we get 13 nodes and 13 links, all distinct
+  Scenario Outline: Vocabulary Linking
+    When we expand "<term>" by <hops> hops at most
+    Then we get these distinct nodes: <nodes>
+
+    Examples: Ancient Greek
+      | term | hops | nodes                                                                                               |
+      | δέ   | 3    | {"aber lieber", "aber", "but", "sed", "ἀλλά", "δέ", "and", "τε", "et", "καί", "also", "even", "δ᾽"} |

features/steps/graphs.py

@@ -11,32 +11,40 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-from behave import *
-from neo4j import GraphDatabase
+import logging
 
+from behave import then
+from behave import when
+from hamcrest import assert_that
+from hamcrest import equal_to
+from neo4j import GraphDatabase
 
-@when("we expand 'δέ' by 3 hops at most")
-def step_impl(context):
-    assert True is not False
+# Set up the logging
+logging.basicConfig(level=logging.INFO)
+neo4j_logger = logging.getLogger("neo4j")
+neo4j_logger.setLevel(logging.DEBUG)  # Log all queries
 
 
-@then('we get 13 nodes and 13 links, all distinct')
-def step_impl(context):
+@when('we expand "{term}" by {num_hops:d} hops at most')
+def step_impl(context, term, num_hops):
     driver = GraphDatabase.driver("neo4j://localhost:7687", auth=("not used", "not used"))
 
     with driver.session() as session:
-        result = parse_apoc_path_expand_result(session.run(
-            """
-            MATCH (node{label:"δέ"})
-            CALL apoc.path.expand(node, "LINK", null, 1, 3)
-            YIELD path
-            RETURN path;
+        context.result = parse_apoc_path_expand_result(session.run(
             """
+                MATCH (node{label:$term})
+                CALL apoc.path.expand(node, "LINK", null, 1, $num_hops)
+                YIELD path
+                RETURN path;
+            """,
+            term=term,
+            num_hops=num_hops
         ))
 
-        print(set(result["nodes"]))
-        assert set(result["nodes"]) == {"aber lieber", "aber", "but", "sed", "ἀλλά", "δέ", "and", "τε", "et", "καί",
-                                        "also", "even", "δ᾽"}
+
+@then('we get these distinct nodes: {nodes}')
+def step_impl(context, nodes):
+    assert_that(set(context.result["nodes"]), equal_to(eval(nodes)))
 
 
 def parse_apoc_path_expand_result(result):

german.yaml

@@ -6083,6 +6083,21 @@ vocabulary:
       - (adv.) over there
       - (adv.) on the other side
     audio: https://upload.wikimedia.org/wikipedia/commons/5/51/De-dr%C3%BCben.ogg
+  - term: die Schweinerei
+    definition: the mess
+    audio: https://upload.wikimedia.org/wikipedia/commons/a/a5/De-Schweinerei.ogg
+    declension:
+      - ["",         singular,    plural       ]
+      - [nominative, Schweinerei, Schweinereien]
+      - [genitive,   Schweinerei, Schweinereien]
+      - [dative,     Schweinerei, Schweinereien]
+      - [accusative, Schweinerei, Schweinereien]
+  - term: vorhin
+    definition: (adv.) recently
+    audio: https://upload.wikimedia.org/wikipedia/commons/5/5d/De-vorhin.ogg
+  - term: wegen
+    definition: (prep.) because of
+    audio: https://upload.wikimedia.org/wikipedia/commons/c/c1/De-wegen2.ogg
 
 
 

requirements.txt

@@ -7,3 +7,4 @@ isort
 
 behave
 neo4j
+PyHamcrest

tests/test_vocabulary_parser.py

@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 import unittest
 
 import yaml